Git fetch -no-tags linux-review Andy-Shevchenko/Input-matrix_keypad-add-missed-header-inclusion/20220924-024709 [If your patch is applied to the wrong git tree, kindly drop us a note.Īnd when submitting patch, we suggest to use '-base' as documented in I love your patch! Yet something to improve: To: Andy Shevchenko, linux-input, linux-kernel +Cc: kbuild-all, Dmitry Torokhov ` (2 subsequent siblings) 4 siblings, 0 replies 14+ messages in threadįrom: kernel test robot 22:42 UTC ( / raw) 19:03 ` Dmitry Torokhov 22:42 ` kernel test robot While I believe this change isĪ good one, we need to fix users of this include first. > +++ b/include/linux/input/matrix_keypad.h > - a/include/linux/input/matrix_keypad.h > diff -git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h > 1 file changed, 3 insertions(+), 2 deletions(-) > include/linux/input/matrix_keypad.h | 5 +++. > When the data structure is only referred by pointer, compiler may not need On Fri, at 09:46:32PM +0300, Andy Shevchenko wrote: ` (3 subsequent siblings) 4 siblings, 1 reply 14+ messages in threadįrom: Dmitry Torokhov 19:03 UTC ( / raw) 18:46 ` Input: matrix_keypad - replace header inclusions by forward declarations Andy 19:03 ` Dmitry Torokhov * Re: Input: matrix_keypad - replace header inclusions by forward declarations > Fixes: f8f7f47d576f ("Input: matrix_keypad - replace of_gpio_named_count() by gpiod_count()") > The gpiod_count() API is defined in gpio/consumer.h. On Fri, at 09:46:31PM +0300, Andy Shevchenko wrote: To: Andy Shevchenko +Cc: linux-input, linux-kernel 18:46 ` Input: matrix_keypad - replace header inclusions by forward declarations Andy 19:01 ` Dmitry Torokhov 1 sibling, 0 replies 14+ messages in threadįrom: Dmitry Torokhov 19:01 UTC ( / raw) 18:46 Input: matrix_keypad - add missed header inclusion Andy Shevchenko * Re: Input: matrix_keypad - add missed header inclusion Include/linux/input/matrix_keypad.h | 5 +++-ġ file changed, 3 insertions(+), 2 deletions(-)ĭiff -git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h When the data structure is only referred by pointer, compiler may not need 18:46 Input: matrix_keypad - add missed header inclusion Andy 18:46 ` Andy Shevchenkoġ sibling, 5 replies 14+ messages in thread * Input: matrix_keypad - replace header inclusions by forward declarations a/drivers/input/keyboard/matrix_keypad.c Include it.įixes: f8f7f47d576f ("Input: matrix_keypad - replace of_gpio_named_count() by gpiod_count()")ĭrivers/input/keyboard/matrix_keypad.c | 1 +ĭiff -git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c The gpiod_count() API is defined in gpio/consumer.h. To: Andy Shevchenko, linux-input, linux-kernel +Cc: Dmitry Torokhov 19:01 ` Input: matrix_keypad - add missed header inclusion Dmitry TorokhovĠ siblings, 2 replies 14+ messages in threadįrom: Andy Shevchenko 18:46 UTC ( / raw) 18:46 ` Input: matrix_keypad - replace header inclusions by forward declarations Andy Shevchenko Input: matrix_keypad - add missed header inclusion LKML Archive on help / color / mirror / Atom feed * Input: matrix_keypad - add missed header inclusion 18:46 Andy Shevchenko
0 Comments
Leave a Reply. |